Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*): Rename refs of MagicLink to EmailLink - deprecation JS Docs #1833

Merged
merged 9 commits into from
Oct 6, 2023

Conversation

dimkl
Copy link
Contributor

@dimkl dimkl commented Oct 5, 2023

Description

Add deprecation JSDocs and export renamed modules/functions/helpers/types to support renaming refs of MagicLink to EmailLink.

Notes

  • another PR with deprecation warnings will follow.
  • MagicLInk refs were removed from clerk-js/src/ui since it's an internal module and they are not exported

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/clerk-js
  • @clerk/clerk-react
  • @clerk/nextjs
  • @clerk/remix
  • @clerk/types
  • @clerk/themes
  • @clerk/localizations
  • @clerk/clerk-expo
  • @clerk/backend
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/fastify
  • @clerk/chrome-extension
  • gatsby-plugin-clerk
  • build/tooling/chore

@dimkl dimkl requested a review from a team as a code owner October 5, 2023 18:01
@dimkl dimkl self-assigned this Oct 5, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2023

🦋 Changeset detected

Latest commit: 335e105

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@clerk/chrome-extension Patch
@clerk/clerk-js Patch
@clerk/nextjs Patch
@clerk/shared Patch
@clerk/clerk-react Patch
@clerk/types Patch
@clerk/clerk-expo Patch
@clerk/backend Patch
@clerk/fastify Patch
@clerk/remix Patch
gatsby-plugin-clerk Patch
@clerk/localizations Patch
@clerk/clerk-sdk-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dimkl dimkl force-pushed the js-643-rename-magiclink-js-docs branch 3 times, most recently from 7f2e5d3 to 216fdbc Compare October 6, 2023 12:47
@LekoArts LekoArts changed the title Chore(*): Rename refs of *MagicLink* to *EmailLink* - deprecation JS Docs chore(*): Rename refs of MagicLink to EmailLink - deprecation JS Docs Oct 6, 2023
Copy link
Member

@BRKalow BRKalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dimkl dimkl force-pushed the js-643-rename-magiclink-js-docs branch from 216fdbc to a141709 Compare October 6, 2023 21:06
@dimkl dimkl force-pushed the js-643-rename-magiclink-js-docs branch from a141709 to 335e105 Compare October 6, 2023 21:18
@dimkl dimkl added this pull request to the merge queue Oct 6, 2023
Merged via the queue into main with commit 7f4d4b9 Oct 6, 2023
6 checks passed
@dimkl dimkl deleted the js-643-rename-magiclink-js-docs branch October 6, 2023 21:43
@clerk-cookie clerk-cookie mentioned this pull request Oct 6, 2023
@clerk-cookie
Copy link
Collaborator

This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@clerk clerk locked as resolved and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants