fix(nextjs): Warn about misplaced middleware file when using auth or getAuth #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d8fd2fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nikosdouvlis
force-pushed
the
nikos/improve-auth-error
branch
from
e2b507c
to
3671507
Compare
SokratisVidros
suggested changes
Oct 17, 2023
nikosdouvlis
force-pushed
the
nikos/improve-auth-error
branch
from
3671507
to
d3f8d5d
Compare
…getAuth For NextJS 13 application, if the `/src` directory is used then the middleware file needs to be nested under it, otherwise the middleware will not run. This is a very common user error - this commit updates the error message to list moving middleware under /src as a potential fix.
nikosdouvlis
force-pushed
the
nikos/improve-auth-error
branch
from
d3f8d5d
to
1a8a55f
Compare
SokratisVidros
approved these changes
Oct 17, 2023
BRKalow
reviewed
Oct 17, 2023
anagstef
approved these changes
Oct 18, 2023
Co-authored-by: Bryce Kalow <bryce@clerk.dev>
Merged
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For NextJS 13 application, if the
/srcdirectory is used then the middleware file needs to be nested under it, otherwise the middleware will not run.This is a very common user error - this commit updates the error message to list moving middleware under /src as a potential fix.
Fixes SDK-818
Description
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore