fix(nextjs): Use dynamic imports in ClerkProvider #2292
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently users of
@clerk/nextjs
and Next.js 12 (or older) are seeing an error when booting up their app:From what I can tell the error must have existed since #1840 was merged. But we only recently got a report about this so hopefully not too many people where impacted 🤞
This only needs to be fixed for v4 (as v5 will drop Next.js 12), so that's why the target branch is
release/v4
.Docs PR: clerk/clerk-docs#543
Root cause
The
packages/nextjs/src/client-boundary/ClerkProvider.tsx
component importsnext/compat/router
and theClerkProvider
for the App router version of Next.js (which usesnext/navigation
).Both imports only got introduced in Next.js 13 so that's why they fail on older versions. webpack tries to resolve these imports, then it fails.
Solution
Dynamic imports! Check if
next/compat/router
can be required, if not we're on Next.js 12 or older and we can use the ClerkProvider for Pages.This works on the client-side, but unfortunately not during compilation of the middleware and other parts of Next.js. So we need to tell our users to let webpack ignore these imports as their code paths won't be hit.
Testing
You can test this change yourself by:
next.config.js
withChecklist
npm test
runs as expected.npm run build
runs as expected.Type of change
Packages affected
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/clerk-expo
@clerk/fastify
gatsby-plugin-clerk
@clerk/localizations
@clerk/nextjs
@clerk/clerk-react
@clerk/remix
@clerk/clerk-sdk-node
@clerk/shared
@clerk/themes
@clerk/types
build/tooling/chore