Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): do not build test file declarations #4286

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

jacekradko
Copy link
Member

Description

Noticed that @clerk/nextjs was building declaration files for files in __tests__ directory. Adding this directory to the exclude in testing tsconfig.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Oct 4, 2024

🦋 Changeset detected

Latest commit: 36649f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jacekradko jacekradko changed the title fix: do not build test file declarations fix(nextjs): do not build test file declarations Oct 4, 2024
Copy link
Member

@brkalow brkalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Co-authored-by: Bryce Kalow <bryce@clerk.dev>
@jacekradko jacekradko marked this pull request as ready for review October 4, 2024 16:02
@jacekradko jacekradko merged commit 0d56455 into main Oct 4, 2024
21 checks passed
@jacekradko jacekradko deleted the fix/no-test-file-declarations branch October 4, 2024 16:13
wobsoriano pushed a commit that referenced this pull request Feb 8, 2025
Co-authored-by: Bryce Kalow <bryce@clerk.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants