Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clerk-js,types): Move to waitlist with email address in combined flow #4615

Conversation

alexcarpenter
Copy link
Member

@alexcarpenter alexcarpenter commented Nov 20, 2024

Description

When waitlist is enabled during combined flow, move to waitlist component with email address pre-populated when user attempts to signup with an email address.

Screen.Recording.2024-11-20.at.12.04.02.PM.mov

Resolves SDKI-744

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Nov 20, 2024

⚠️ No Changeset found

Latest commit: be94d6d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

alexcarpenter and others added 3 commits November 20, 2024 13:30
Co-authored-by: Dylan Staley <88163+dstaley@users.noreply.github.com>
…rk/javascript into alexcarpenter/combined-flow-waitlist
@alexcarpenter alexcarpenter marked this pull request as ready for review November 20, 2024 18:41
Copy link
Member

@BRKalow BRKalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 9:31pm

@alexcarpenter alexcarpenter merged commit 78c045c into alexcarpenter/sign-in-up-flow-init Nov 20, 2024
6 checks passed
@alexcarpenter alexcarpenter deleted the alexcarpenter/combined-flow-waitlist branch November 20, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants