Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shared): Gracefully handle missing reverification error metadata #4636

Merged
merged 1 commit into from
Nov 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/many-bees-mate.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/shared': patch
---

Gracefully handle missing reverification error metadata
2 changes: 1 addition & 1 deletion packages/shared/src/authorization-errors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ type ReverificationError<M extends { metadata?: any } = { metadata: unknown }> =
const reverificationError = <MC extends ReverificationConfig>(
missingConfig?: MC,
): ReverificationError<{
metadata: {
metadata?: {
reverification?: MC;
};
}> => ({
Expand Down
6 changes: 5 additions & 1 deletion packages/shared/src/authorization.ts
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,11 @@ const checkOrgAuthorization: CheckOrgAuthorization = (params, options) => {
return null;
};

const validateReverificationConfig = (config: ReverificationConfig | undefined) => {
const validateReverificationConfig = (config: ReverificationConfig | undefined | null) => {
if (!config) {
return false;
}

const convertConfigToObject = (config: ReverificationConfig) => {
if (typeof config === 'string') {
return TYPES_TO_OBJECTS[config];
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/src/react/hooks/useReverification.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ function createReverificationHandler(params: CreateReverificationHandlerParams)
*/
const resolvers = createDeferredPromise();

const isValidMetadata = validateReverificationConfig(result.clerk_error.metadata.reverification);
const isValidMetadata = validateReverificationConfig(result.clerk_error.metadata?.reverification);

/**
* On success resolve the pending promise
Expand Down
Loading