chore(nextjs): Warn for deprecated nextjs versions #4657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panteliselef
requested review from
dstaley,
jacekradko,
BRKalow and
nikosdouvlis
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
🦋 Changeset detectedLatest commit: 431c808 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dstaley
reviewed
Nov 26, 2024
| @@ -24,6 +26,12 @@ declare global { | |||
| } | |||
|
|
|||
| export const ClientClerkProvider = (props: NextClerkProviderProps) => { | |||
| if (nextPackage.version.startsWith('13.') || nextPackage.version.startsWith('14.0')) { | |||
| logger.warnOnce( | |||
| `\n\x1b[43m----------\n[Clerk]: Your current nextjs version (${nextPackage.version}) will be deprecated in the next major release of "@clerk/nextjs". Please upgrade to >= next@14.2 .\n----------\x1b[0m\n`, | |||
There was a problem hiding this comment.
Suggested change
| `\n\x1b[43m----------\n[Clerk]: Your current nextjs version (${nextPackage.version}) will be deprecated in the next major release of "@clerk/nextjs". Please upgrade to >= next@14.2 .\n----------\x1b[0m\n`, | |
| `\n\x1b[43m----------\n[Clerk]: Your current Next.js version (${nextPackage.version}) will be deprecated in the next major release of "@clerk/nextjs". Please upgrade to next@14.2.0 or later.\n----------\x1b[0m\n`, |
anagstef
reviewed
Nov 27, 2024
anagstef
approved these changes
Nov 27, 2024
Co-authored-by: Stefanos Anagnostou <anagstef@users.noreply.github.com>
LekoArts
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have found a few issues in the Next.js from version 13.5 to 14.0.4. We should advices our customers to upgrade. Also warn them about those versions becoming deprecated in the future.
how it looks on terminal
how it looks on chrome
how it looks on safari
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change