-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support bigint cell content type #340
Conversation
Thanks for the PR(s)! I'd like to see a supporting test that simply outputs a bigint in cell content and the resulting output is as expected. This would be more to avoid regressions when refactoring. I'll create a new release next week. If you haven't added a test, I'll accept this as is. |
You'll find basic examples for issue based tests here: https://github.com/cli-table/cli-table3/tree/master/test/issues |
Added a test. Also had to update the eslint |
@@ -1,6 +1,6 @@ | |||
module.exports = { | |||
parserOptions: { | |||
ecmaVersion: 2018, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure whether this should be considered a "breaking change". If it is, a major release still seems like overkill.
Thanks for your efforts. Tests look good. Your placement of them (within |
The existing type casting (
String(value)
) also works forBigInt
s, so I've added support in the Typescript definitions and the JS type checks.