Emoji Length Calculation Fix #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@acupoftee it seems that you used |
|
Will do |
Turbo87
reviewed
Mar 12, 2019
Turbo87
added a commit
to boneskull/cli-table3
that referenced
this pull request
May 1, 2019
This reverts commit c1fb59c.
Merged
|
@acupoftee I've had to revert this PR in #103 because we discovered that it was responsible for the test suite failing 😢 it seems that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with emoji padding inside table cells. For example, this was the result when the calculations used the
string-widthmodule:It turned out that
stringWidth(s)inutils.js:13returned the wrong length. The unicode length for the should be1, howeverstringWidth("🇯🇵")returns2.This was corrected using the unicode-aware module Stringz. This PR is to use Stringz to return the correct emoji length and render the correct output as seen below: