Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GH_HOST and expose repository.Parse #12

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

samcoe
Copy link
Contributor

@samcoe samcoe commented Jan 10, 2022

This PR adds support for the GH_HOME environment variable to the CurrentRepository function. To support this new functionality I added a new function Parse to the new repository package. The Parse function is exported as the operation of parsing a string into its repository information seems like a useful utility for extension authors to have.

Closes #8

@samcoe samcoe self-assigned this Jan 10, 2022
@samcoe samcoe force-pushed the improve_current_repository branch from 494f5f2 to 58f1e18 Compare January 10, 2022 13:39
@samcoe samcoe marked this pull request as ready for review January 10, 2022 13:57
@samcoe samcoe requested review from mislav and vilmibm January 10, 2022 13:57
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great; I'm just wondering if we could improve the API for parsing git remote URLs?

internal/git/url.go Show resolved Hide resolved
@samcoe samcoe merged commit e7b2b83 into trunk Jan 19, 2022
@samcoe samcoe deleted the improve_current_repository branch January 19, 2022 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for GH_REPO environment variable
2 participants