Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #3

Merged
merged 2 commits into from
Nov 29, 2021
Merged

Update README.md #3

merged 2 commits into from
Nov 29, 2021

Conversation

vilmibm
Copy link
Contributor

@vilmibm vilmibm commented Nov 29, 2021

  • add note about beta
  • explain the two general ways to use gh stuff
  • add another example showing an alternative to Exec

An open question: I'd like to be able to point at reference docs. are we generating those?

@vilmibm vilmibm requested a review from samcoe November 29, 2021 17:48
samcoe
samcoe approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@samcoe samcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the clean up. Reference docs are https://pkg.go.dev/github.com/cli/go-gh and are automatically generated by pkg.go.dev.

@vilmibm vilmibm merged commit 3a8fab4 into trunk Nov 29, 2021
@vilmibm vilmibm deleted the vilmibm-patch-1 branch November 29, 2021 23:05
@kdcloverkid

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samcoe samcoe samcoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vilmibm @kdcloverkid @samcoe