Add support for http_unix_socket #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcoe
commented
May 10, 2022
samcoe
commented
May 13, 2022
samcoe
commented
May 13, 2022
samcoe
commented
May 13, 2022
mislav
approved these changes
May 17, 2022
gh.go
Outdated
| return err | ||
| var notFoundError iconfig.NotFoundError | ||
| if errors.As(err, ¬FoundError) { | ||
| return fmt.Errorf("auth token not found for host %s", opts.Host) |
There was a problem hiding this comment.
Nit: "authentication token" instead of "auth token"
Also, should this error be of a unique type so that integrators can handle it specifically?
There was a problem hiding this comment.
I think that is a good idea, but can be implemented in a follow up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for automatically resolving
ghconfighttp_unix_socket.Closes #2
cc cli/cli#5560