-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add govulncheck action #71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL govulncheck
! How does it compare to Dependabot security alerts, which we currently have enabled?
@mislav So there are two major difference from my understanding:
I mostly want to enable this side by side with |
.github/workflows/vuln.yml
Outdated
@@ -0,0 +1,28 @@ | |||
name: Vulnerability Check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this has exactly the same triggers as the Code Scanning
workflow, I would say that this could be folded in as a separate job under that workflow, rather than as a workflow of its own. At the end of the day, they both perform static analysis to find vulnerabilities
@@ -12,7 +10,7 @@ jobs: | |||
- name: Set up Go | |||
uses: actions/setup-go@v3 | |||
with: | |||
go-version: "1.18" | |||
go-version: "1.19" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we still run our tests on 1.18 maybe it would make sense to continue running linter an govulncheck on 1.18 as well. Or do you think matching these versions doesn't matter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it makes much difference. I purposefully put the linter to 1.19 as there are new godoc features/rules in 1.19 that I wanted to start enforcing in this repo.
This PR adds an action for the new
govulncheck
tool to check for vulnerabilities in our dependencies.