Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(makefile): Add missing dependencies from src/common/* #303

Merged
merged 1 commit into from
Dec 15, 2023
Merged

fix(makefile): Add missing dependencies from src/common/* #303

merged 1 commit into from
Dec 15, 2023

Conversation

hyperupcall
Copy link
Contributor

@hyperupcall hyperupcall commented Dec 15, 2023 •
edited
Loading

As noted in the issue, when files like src/common/clib-cache.c were modified, running make did not rebuild clib. Now, it does.

Closes #298
Closes #284
Closes #276

stephenmathieson
stephenmathieson approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@stephenmathieson stephenmathieson merged commit 2e8f12f into clibs:master Dec 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmathieson stephenmathieson stephenmathieson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Makefile dependency Bug dependency errors Document clib.json license values
2 participants
@hyperupcall @stephenmathieson