Added relevant code and tests for the new fix #97 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the code to work with the custom resolve context function: click_repl/_completer.py Added checks for empty optional-Arguments: click_repl/_repl.py Added InvalidGroupFormat Exception class: click_repl/exceptions.py Added custom resolve context function: click_repl/utils.py
(Added Context object to all the completer instances)
Moved mock_stdin to init file: tests/__init__.py Added some more parametrized tests for new fix#92: tests/test_repl.py
GhostOps77
changed the title
auvipy
requested changes
May 21, 2023
|
@auvipy i haven't done any py2 cleanup anywhere It would be helpful for me if u can point me where i've done those changes |
…#97" This reverts commit 6b8617e.
This reverts commit f3694c7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the updated code that generates suggestions based on the recent fix #97
More tests were included as well
Also, completely resolves #92