Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactor and some other bits #32

Merged
merged 4 commits into from
Jul 2, 2017
Merged

Small refactor and some other bits #32

merged 4 commits into from
Jul 2, 2017

Conversation

decentral1se
Copy link
Contributor

@decentral1se decentral1se commented Jul 1, 2017 •
edited
Loading

I was on the way to doing something for #15 and ended up doing all of this.

Best to submit early and see what you all think.

@untitaker
Copy link
Collaborator

Pipenv: I really don't want to support a third-party package manager.

The rest LGTM, thanks!

@decentral1se
Copy link
Contributor Author

OK, droped that pipenv commit and fixed the build 👍

@untitaker untitaker merged commit 90354da into click-contrib:master Jul 2, 2017
@untitaker
Copy link
Collaborator

Thanks!

@decentral1se decentral1se deleted the refactor+add+script branch July 2, 2017 21:16
@untitaker untitaker mentioned this pull request Nov 27, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@decentral1se @untitaker