Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(linkTools.Arrowhead): fix to trigger missing paper pointerdown event #2625

Merged
merged 1 commit into from
Apr 23, 2024
Merged

fix(linkTools.Arrowhead): fix to trigger missing paper pointerdown event #2625

merged 1 commit into from
Apr 23, 2024

Conversation

kumilingus
Copy link
Contributor

Description

When the user drags the arrowhead of a link (either by dragging the port or using the linkTools.Arrowhead tool), the following events are triggered on paper:

'link:pointerdown' (1)
'link:pointermove' (0+)
 link:pointerup' (1)

However, in the case of linkTools.TargetArrowhead and linkTools.SourceArrowhead the link:pointerdown event was missing.

Note: it applies to cell:pointerdown event too.

@kumilingus kumilingus requested a review from zbynekstara April 23, 2024 07:50
@kumilingus kumilingus merged commit a383dee into clientIO:master Apr 23, 2024
3 checks passed
@kumilingus kumilingus deleted the arrowhead-events branch April 23, 2024 13:57
@kumilingus kumilingus mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbynekstara zbynekstara zbynekstara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kumilingus @zbynekstara