Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows builds are failing #11

Open
brian-rose opened this issue Jul 5, 2022 · 9 comments
Open

Windows builds are failing #11

brian-rose opened this issue Jul 5, 2022 · 9 comments

Comments

@brian-rose
Copy link
Collaborator

As of last week, all the Windows builds are failing, e.g.
https://github.com/climlab/climlab-rrtmg/actions/runs/2573863846

Haven't started to look at why.

@brian-rose
Copy link
Collaborator Author

The failure occurs after the build step and during the import climlab_rrtmg step:

Run python -c "import climlab_rrtmg"
[2](https://github.com/climlab/climlab-rrtmg/runs/7086194845?check_suite_focus=true#step:6:2)
  python -c "import climlab_rrtmg"
[3](https://github.com/climlab/climlab-rrtmg/runs/7086194845?check_suite_focus=true#step:6:3)
  python -c "from climlab_rrtmg import rrtmg_lw, rrtmg_sw"
[4](https://github.com/climlab/climlab-rrtmg/runs/7086194845?check_suite_focus=true#step:6:4)
  shell: C:\Windows\System32\WindowsPowerShell\v1.0\powershell.EXE -command ". '{0}'"
[5](https://github.com/climlab/climlab-rrtmg/runs/7086194845?check_suite_focus=true#step:6:5)
  env:
[6](https://github.com/climlab/climlab-rrtmg/runs/7086194845?check_suite_focus=true#step:6:6)
    CONDA: C:\Miniconda3
[7](https://github.com/climlab/climlab-rrtmg/runs/7086194845?check_suite_focus=true#step:6:7)
    CONDA_PKGS_DIR: C:\Users\runneradmin\conda_pkgs_dir
[8](https://github.com/climlab/climlab-rrtmg/runs/7086194845?check_suite_focus=true#step:6:9)
Traceback (most recent call last):
[9](https://github.com/climlab/climlab-rrtmg/runs/7086194845?check_suite_focus=true#step:6:10)
  File "<string>", line 1, in <module>
[10](https://github.com/climlab/climlab-rrtmg/runs/7086194845?check_suite_focus=true#step:6:11)
  File "D:\a\climlab-rrtmg\climlab-rrtmg\climlab_rrtmg\rrtmg_lw\__init__.py", line 2, in <module>
[11](https://github.com/climlab/climlab-rrtmg/runs/7086194845?check_suite_focus=true#step:6:12)
    from ._rrtmg_lw import *
[12](https://github.com/climlab/climlab-rrtmg/runs/7086194845?check_suite_focus=true#step:6:13)
ImportError: DLL load failed while importing _rrtmg_lw: The specified module could not be found.
[13](https://github.com/climlab/climlab-rrtmg/runs/7086194845?check_suite_focus=true#step:6:14)
Error: Process completed with exit code 1.

@brian-rose
Copy link
Collaborator Author

In #13 I tried removing the Windows compiler step

echo "[build]`ncompiler=mingw32" | Out-File -Encoding ASCII ~/pydistutils.cfg

(which used to be necessary)

Get exactly the same failure as above.

Something must have changed upstream so that a different configuration command is necessary. That's as far as I've gotten.

@brian-rose
Copy link
Collaborator Author

I may be clueing into the fact that, although we include flang in the environment, we are not actually using it for the f2py build. Instead using some version of mingw that is pre-installed on the Windows runner.

May need to include some code to instruct f2py to use flang instead.

@dorrih
Copy link

dorrih commented Jun 28, 2023

Hello, I see that this issue is open since July 2022.
I tried to build today (end of June 2023), and the build was successful (no indication of any warning or error), but the tests fail (missing dll's).
Is there any news about this issue? Thank you

@brian-rose
Copy link
Collaborator Author

No news, sorry. Unfortunately I don't use windows myself so I have very little useful knowledge about how to solve this. I would love some help!

There are working binaries available on conda-forge though, so most users don't need to build from source.

@dorrih
Copy link

dorrih commented Jun 28, 2023 via email

@brian-rose
Copy link
Collaborator Author

You could try following these build instructions and use ./ci/requirements-linux.yml. I would be curious to hear if it works.

@dorrih
Copy link

dorrih commented Jun 29, 2023 via email

@brian-rose
Copy link
Collaborator Author

Great! Thanks @dorrih for reporting this workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants