Minor change to descendant_tree to apply recent Haplotype changes to SimpleAllele and add a self-contained test #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe. Add stripped down descendant_tree test for all types
toneillbroad
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make SimpleAllele descendant_tree handling match haplotype and genotype. Add stripped down descendant_tree test for all types.
This does not affect outputs for real XML inputs because SimpleAlleles don't have descendants, but this does impact intermediate data structures and just makes the layout of the tree for each variant type the same which may help consistency when debugging.
It also adds a test that defines the most simple structure of variants that can be passed into
Variation.descendant_treeand validates the return value for every type on its own and in combination.