Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accept --name argument #399

Merged
merged 1 commit into from
Mar 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ clinic heapprofiler --help
--autocannon Run the autocannon benchmarking tool when the server starts listening on a port.
--dest Destination for the collect data (default .).
--stop-delay Add a delay to close the process when a job is done through either `autocannon` or `on-port` flag (milliseconds)
--name The --name flag sets a name for the output data, allowing you to replace existing reports without generating new ones. Example: <code>.clinic/node-19-test.clinic-flame</code>
```

## Programmable Interfaces
Expand Down
15 changes: 10 additions & 5 deletions bin.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ const result = commist()
'sample-interval',
'on-port',
'dest',
'stop-delay'
'stop-delay',
'name'
],
default: {
'sample-interval': '10',
Expand Down Expand Up @@ -119,7 +120,8 @@ const result = commist()
string: [
'visualize-only',
'dest',
'stop-delay'
'stop-delay',
'name'
],
default: {
open: true,
Expand Down Expand Up @@ -161,7 +163,8 @@ const result = commist()
string: [
'visualize-only',
'dest',
'stop-delay'
'stop-delay',
'name'
],
default: {
open: true,
Expand Down Expand Up @@ -202,7 +205,8 @@ const result = commist()
string: [
'visualize-only',
'dest',
'stop-delay'
'stop-delay',
'name'
],
default: {
open: true,
Expand Down Expand Up @@ -323,7 +327,8 @@ async function runTool (toolName, Tool, version, args, uiOptions) {
detectPort: !!onPort,
dest: args.dest,
debug: args.debug,
kernelTracing: args['kernel-tracing']
kernelTracing: args['kernel-tracing'],
name: args.name
})

const stopDelayMs = parseInt(args['stop-delay'])
Expand Down
1 change: 1 addition & 0 deletions docs/clinic-bubbleprof.txt
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,4 @@
--open Boolean to enable or disable your report opening in your web browser.
--dest Destination for the collected data (default <code>.clinic/</code>).
--stop-delay Add a delay to close the process when a job is done through either `autocannon` or `on-port` flag (milliseconds)
--name The --name flag sets a name for the output data, allowing you to replace existing reports without generating new ones. Example: <code>.clinic/node-19-test.clinic-flame</code>
1 change: 1 addition & 0 deletions docs/clinic-doctor.txt
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,4 @@
--open Boolean to enable or disable your report opening in your web browser.
--dest Destination for the collected data (default <code>.clinic/</code>).
--stop-delay Add a delay to close the process when a job is done through either `autocannon` or `on-port` flag (milliseconds)
--name The --name flag sets a name for the output data, allowing you to replace existing reports without generating new ones. Example: <code>.clinic/node-19-test.clinic-flame</code>
1 change: 1 addition & 0 deletions docs/clinic-flame.txt
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,4 @@
--dest Destination for the collected data (default <code>.clinic/</code>).
--kernel-tracing Profile application using linux_perf (linux only).
--stop-delay Add a delay to close the process when a job is done through either `autocannon` or `on-port` flag (milliseconds)
--name The --name flag sets a name for the output data, allowing you to replace existing reports without generating new ones. Example: <code>.clinic/node-19-test.clinic-flame</code>
1 change: 1 addition & 0 deletions docs/clinic-heap-profiler.txt
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,4 @@
--open Boolean to enable or disable your report opening in your web browser.
--dest Destination for the collected data (default <code>.clinic/</code>).
--stop-delay Add a delay to close the process when a job is done through either `autocannon` or `on-port` flag (milliseconds)
--name The --name flag sets a name for the output data, allowing you to replace existing reports without generating new ones. Example: <code>.clinic/node-19-test.clinic-flame</code>