-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ruby deprecation warning #69
base: master
Are you sure you want to change the base?
Conversation
166cf58
to
a668f49
Compare
a668f49
to
4c505d9
Compare
@@ -22,6 +22,7 @@ | |||
require 'jit_preloader/preloader' | |||
|
|||
module JitPreloader | |||
Warning[:deprecated] = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it will set Warning[:deprecated]
true when this file gets parsed. Is that what we want? Shouldn't we be isolating this to the specs for this gem, putting that line in the spec_helper.rb file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point of this PR is to enable deprecated warnings with CI run so they can be fixed. However, the PR does not intend to be merged, so I think it matters little where I put it as long as it enables the warnings properly.
Enable ruby deprecation warning to find any codes that need refactoring before upgrading to ruby 3.
This PR is only for triggering the ci and inspecting the tests log for deprecation warnings, not for merge.