Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix style injection in pages + optimizations #67

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Fix style injection in pages + optimizations #67

merged 1 commit into from
Dec 4, 2018

Conversation

remusao
Copy link
Collaborator

@remusao remusao commented Dec 3, 2018 •
edited
Loading

Fix style injection and cosmetic filtering logic #67

  • All cosmetics are now using only one background action (instead of two)
  • No unloading is needed in content-script anymore
  • Simplified and optimized the implementation of CosmeticBucket
  • Internalized the version of serialized engine for auto-invalidation on update

@remusao remusao added WIP and removed WIP labels Dec 3, 2018
@remusao remusao force-pushed the fix-cosmetics-injection branch 5 times, most recently from 72283ab to 2e2561b Compare December 4, 2018 12:16
@remusao remusao force-pushed the fix-cosmetics-injection branch from 2e2561b to 029b929 Compare December 4, 2018 12:26
@remusao remusao merged commit 3f68596 into ghostery:master Dec 4, 2018
@remusao remusao mentioned this pull request Dec 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhonghao-cliqz zhonghao-cliqz zhonghao-cliqz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remusao @zhonghao-cliqz