Add Sentence case and Title Case for string output #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for the use-case of formatting a keyword or other symbol into something which you might show to the user in a plain sentence, addressing Feature requests clj-commons#74 and clj-commons#37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for the use-case of formatting a keyword or other symbol into something which you might show to the user in a plain sentence, addressing Feature requests #74 and #37
The main niggle here is that the naming scheme of the functions matches the output, which obviously can't contain a space. I have offered the compromise of stripping spaces from symbol names as they are unusable (though interestingly allowable).
I've also opted for simply "Sentence" and "Title", again for readability so we don't end up with e.g.
->Sentencecasesymbol. I'd be happy to update based on any feedback.I haven't tested this on cljs, but I'm pretty sure I haven't added anything problematic there