-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: deploy job fails for PRs #40
Comments
@slipset, I think CircleCI allows us to trigger a job based on a matching tag only. We currently have: workflows:
build-deploy:
jobs:
- build:
filters:
tags:
only: /.*/
- deploy:
requires:
- build
filters:
tags:
only: /Release-.*/
context:
- CLOJARS_DEPLOY Unlike GitHub Actions, for CircleCI we can say, hey, only execute on matching tag please via - deploy:
requires:
- build
filters:
tags:
only: /Release-.*/
branches:
ignore: /.*/
context:
- CLOJARS_DEPLOY This is a confusing syntax, but I think it says don't trigger on any branch criteria, just trigger if you see a matching tag. Is this what you'd like to happen? |
Doing a little grep.apping tells me folks are using this pattern. I think I'm going to go ahead and PR this. Can adapt if that turns out not to work out for you/us. |
I think we can just not invoke this job if not on main branch?
I can take a look.
The text was updated successfully, but these errors were encountered: