You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm using ring/compojure to run my JSON api server
I use the wrap-instrumentation ring collector as a middleware to report prometheus metrics
My problem is that the current collector does not report thrown exceptions as 5XX status class to the http_requests_total metric
I know it increments http_exceptions_total but I still find it strange that if I those exceptions are not counted anywhere in the requests total or the latency histogram
I guess my questions are:
Have I missed anything or is this the behavior the ring collector works with?
If this is the current behavior I would like to suggest a new parameter to the options map, let's call it :exception-response which is a ring map - for example {:status 500 :body "something bad happened"}
we can then use the record-metrics! on the ring map in case we have exception here to have both HTTP response code and latency monitored in case of a thrown exception
would be happy to get your opinion on this
The text was updated successfully, but these errors were encountered:
…mmons#49)
The old behaviour was not to report thrown exceptions as 5XX status class to the http_requests_total metric.
This change gives the client the option to count exceptions in the total as well as exceptions.
Please refer to the Readme for further details.
I'm using ring/compojure to run my JSON api server
I use the
wrap-instrumentation
ring collector as a middleware to report prometheus metricsMy problem is that the current collector does not report thrown exceptions as 5XX status class to the
http_requests_total
metricI know it increments
http_exceptions_total
but I still find it strange that if I those exceptions are not counted anywhere in the requests total or the latency histogramI guess my questions are:
:exception-response
which is a ring map - for example{:status 500 :body "something bad happened"}
we can then use the
record-metrics!
on the ring map in case we have exception here to have both HTTP response code and latency monitored in case of a thrown exceptionwould be happy to get your opinion on this
The text was updated successfully, but these errors were encountered: