Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up formatting (1/2) and updated dependencies #147

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from

Conversation

clojens
Copy link

@clojens clojens commented Jun 29, 2013

I'll see if I can clean up some of the 80 lines sometime but really think it's too much work. This wasn't tho.

@daveray
Copy link
Collaborator

daveray commented Jul 3, 2013

Hi. Two things:

  • It looks like you made all these changes on master rather than develop hence all the "Merge branch xxx" commits in the pull request. Could you make these changes on develop?
  • There are a lot of similar or non-descriptive commits here. Could you squash them into a single commit, or smaller set of focused commits?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants