Deprecate --dependency-check-properties command line option
#107
Comments
|
Yes, PR please -- it'll give me more insight into the CLI lib... |
|
I like babashka.cli because it is helpful but not rigid. |
lread
added a commit
to lread/clj-watson
that referenced
this issue
Aug 19, 2024
Don't show it in usage help. Don't describe it in README. Emit warning when it is used. Close clj-holmes#107
lread
added a commit
to lread/clj-watson
that referenced
this issue
Aug 19, 2024
Don't show it in usage help. Don't describe it in README. Emit warning when it is used. Closes clj-holmes#107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From #106 (comment)
Currently
The
--dependency-check-propertiesis more confusing than helpful, and is superseded by--clj-watson-properties.So
Let's go ahead and deprecate it.
Ideas for deprecating -d
Option 1: Do nothing - continue to support.
Con: The option is confusing
Con: we have to maintain and make sure it works
Option 2: Turf it, breaking change.
This seems ok to me.
Con: breaks usage for x number of users. Maybe x = 0?
Pro: simplifies our life.
Option 3: Stop documenting the feature and warn if it is used.
Usage and README would not describe the feature and warn that it is slated for deletion if used.
Pro: gives users time to adapt.
Con: It is a burden on us to test/support for a bit longer.
Decision
@seancorfield has chosen option 3 for now.
A future release will likely implement option 2.
Next Steps
I can follow up with PR if that would help you.
The text was updated successfully, but these errors were encountered: