-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider Cutting Down on the Logging Noise at Startup #69
Comments
It seems like all that |
Does this tie in to #68 ? |
Ya is certainly related to #68. Since clj-watson turns off logging via slf4j-nop, we can assume that these logs lines are not redirected through slf4j. I think by default Apache Commons JCS uses JUL but can be told to use log4j2. |
Ok @seancorfield, I've got something working locally. It makes sense to switch from slf4j-nop to something real. |
We could have continued with slf4-nop, but I opted to switch to logback-classic to exercise suppression of Apache Commons JCS `INFO` level logging. This enables logging in general. Relates to: - clj-holmes#68 you'll see dependency-check logging during db download/update - clj-holmes#67 you'll see dependency-check warn about lack of nvd api key I chose a log pattern I thought might work. We can revisit, if necessary, in a separate issue. Closes clj-holmes#69
We could have continued with slf4-nop, but I opted to switch to logback-classic to exercise suppression of Apache Commons JCS `INFO` level logging. This enables logging in general. Relates to: - #68 you'll see dependency-check logging during db download/update - #67 you'll see dependency-check warn about lack of nvd api key I chose a log pattern I thought might work. We can revisit, if necessary, in a separate issue. Closes #69
Currently
When clj-watson starts up it emits quite a few log lines, here's an example:
My Take
Because the presentation is noisy and repetitive I am likely to just skip over the entire log.
The only thing I see that seems relevant to me is the cache file root directory.
As a user, I ask myself why a tool is telling me things I do not need to know.
And then I wonder if maybe I do need to know about these things it is telling me.
And then I feel a bit annoyed with the tool when I realize I probably don't.
Proposal
Look into a way to reduce this startup log noise to maybe:
Next Steps
If you agree, I can look into this more and follow up with a PR.
The text was updated successfully, but these errors were encountered: