Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clj-time is deprecated #83

Closed
lread opened this issue Aug 3, 2024 · 2 comments · Fixed by #91
Closed

chore: clj-time is deprecated #83

lread opened this issue Aug 3, 2024 · 2 comments · Fixed by #91

Comments

@lread
Copy link
Contributor

lread commented Aug 3, 2024

Clj-watson is using clj-time, which has been deprecated.

Consider replacing.
@lread
Copy link
Contributor Author

lread commented Aug 4, 2024

@seancorfield do you have a preferred time lib? Or do you prefer Java interop?
It does not look like clj-watson is doing anything terribly fancy or complex.

@seancorfield
Copy link
Contributor

Plain Java interop ought to be fine. At work we replaced clj-time usage with Java Time interop (although we went via clojure.java-time in some places, but we've weaned ourselves off that too now).

lread added a commit to lread/clj-watson that referenced this issue Aug 5, 2024
@lread
Replace deprecated clj-time dep
a584230 
Replaced with JDK8 java.time interop.

Closes clj-holmes#83
lread added a commit to lread/clj-watson that referenced this issue Aug 5, 2024
@lread
Replace deprecated clj-time dep
9496c7d 
Replaced with JDK8 java.time interop.

Closes clj-holmes#83
lread added a commit to lread/clj-watson that referenced this issue Aug 5, 2024
@lread
Replace deprecated clj-time dep
560e1a9 
Replaced with JDK8 java.time interop.

Retained treating date/times as UTC.

Closes clj-holmes#83
@lread lread mentioned this issue Aug 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace deprecated clj-time dep lread/clj-watson
2 participants
@seancorfield @lread