Show short summary of findings #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include a 2-line summary of findings that reports the number of dependencies scanned, vulnerabilities found, and vulnerabilities broken down by severity. The break down by severity makes no effort to distinguish between CVSS2, CVSS3 and CVSS4 scores. For example, CVSS2 has no Critical severity, so a High CVSS2 could be classified as a Critical CVSS3/CVSS4. For a summary, I think this is fine. Accounts for possibility that data might have unspecified or unrecognized severity values. I think this is less likely for dependency-check (at least today as I've looked at the downloaded db), but have less of an idea of what values github-advisory might return. Some minor cleanups in touched code: - de-duplicated shared scan logic in entrypoint ns - moved logging setup to logging-config ns - change kaocha test reporter to show tests being run Closes clj-holmes#87
|
Hiya @seancorfield! When you find some time and interest, lemme know what you think. |
|
I'm dedicating a few days in the second half of this week to OSS so I'll take a look in a few days. |
|
Very nice refactorings there -- thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include a 2-line summary of findings that reports the number of dependencies scanned, vulnerabilities found, and vulnerabilities broken down by severity.
The break down by severity makes no effort to distinguish between CVSS2, CVSS3 and CVSS4 scores. For example, CVSS2 has no Critical severity, so a High CVSS2 could be classified as a Critical CVSS3/CVSS4. For a summary, I think this is fine.
Accounts for possibility that data might have unspecified or unrecognized severity values. I think this is less likely for dependency-check (at least today as I've looked at the downloaded db), but have less of an idea of what values github-advisory might return.
Some minor cleanups in touched code:
Closes #87