Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multiple vulnerability database strategies (github advisory and dependency-check) #14

Merged
merged 26 commits into from
Feb 18, 2022

Conversation

mthbernardes
Copy link
Contributor

@mthbernardes mthbernardes commented Feb 16, 2022

Support Github advisory database.

Pros

  • Faster execution.
  • Lookup by dependency-name.
  • Possible to generate a binary using graalvm.
  • Not necessary to mantain a DB like in dependency-check.
  • Code much more simple.

Cons

  • Lookup vulnerabilities by dependency name so in case of a dependency with a different name in the advisory it will not find the vulnerability (E.g.: org.jdom/jdom2 / org.jdom/jdom)
  • Github token necessary
  • Rate Limit
  • It's possible to execute it using a Github action token but it has a rate limit of 5k.

Issues

  • Support git version when looking up for fixes.

@mthbernardes mthbernardes marked this pull request as draft February 16, 2022 03:35
@mthbernardes mthbernardes marked this pull request as ready for review February 18, 2022 03:27
@mthbernardes mthbernardes self-assigned this Feb 18, 2022
@mthbernardes mthbernardes changed the title poc using github advisory db instead of dependency-check support multiple vulnerability database strategies (github advisory and dependency-check) Feb 18, 2022
@mthbernardes mthbernardes merged commit b93c486 into main Feb 18, 2022
@mthbernardes mthbernardes deleted the poc-remove-dependency-check branch February 18, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant