Add a feature to load migrations from a directory #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czocher
force-pushed
the
from-directory
branch
2 times, most recently
from
fa0576a
to
efb4764
Compare
czocher
changed the title
|
Required PRs were merged, marking TODO as done. Rebased the PR on top of master. It's ready for review. |
cljoly
reviewed
Mar 17, 2023
cljoly
reviewed
Mar 17, 2023
cljoly
reviewed
Mar 17, 2023
czocher
force-pushed
the
from-directory
branch
9 times, most recently
from
88d026f
to
2d0470a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
cljoly
reviewed
Mar 19, 2023
czocher
force-pushed
the
from-directory
branch
10 times, most recently
from
17611eb
to
348e92f
Compare
cljoly
reviewed
Mar 20, 2023
czocher
force-pushed
the
from-directory
branch
12 times, most recently
from
cce7fbe
to
c9597fd
Compare
cljoly
reviewed
Apr 1, 2023
There was a problem hiding this comment.
Thanks for the thorough documentation and testing. I’ve posted quite a few comments, but some are for follow-up work. I think we are getting close to being able to merge!
The subdirectory idea is also much simpler, it could pave the way (in a future PR) to dropping the from_directory dependency and to using our own macro, for the sake of runtime efficiency (the readme should be updated then and tradeoff between compile-time and run-time costs explained)
czocher
force-pushed
the
from-directory
branch
5 times, most recently
from
a1e2be8
to
23d8c19
Compare
This was referenced Apr 3, 2023
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a new feature
from-directorywhich allows to specify a directory used to load migrations from and store them in the binary.This implementation assumes that the directory contains
*.sqlfiles with a documented naming pattern.Closes #37.
TODO:
AsyncMigrations::newdocumentation #50, Fix example test #49 and Fix problems and improve tests according tocargo mutants#47 before we can merge this. Afterwards the PR should be rebased on top of themasterbranch.@cljoly feel free to have a first look and review.