Remove implicit transactions and thread the Tx instead (#65)

* Remove implicit transactions and thread the Tx instead

* Split logic for proper Tx handling

crates/cli/Cargo.toml

@@ -39,7 +39,7 @@ termcolor = "1.2.0"
 is-terminal = "0.4"
 futures = "0.3"
 tempfile = "3.3"
-rustyline =  { version = "11.0.0", features = [] }
+rustyline =  { version = "12.0.0", features = [] }
 syntect = { version = "5.0.0", default-features = false, features = ["default-fancy"]}
 wasmbin = "0.6"
 itertools = "0.10"

crates/cli/src/subcommands/repl.rs

@@ -1,7 +1,6 @@
 use crate::api::{ClientApi, Connection};
 use crate::sql::run_sql;
 use colored::*;
-use std::io::Write;
 
 use rustyline::completion::Completer;
 use rustyline::error::ReadlineError;
@@ -64,9 +63,7 @@ pub async fn exec(con: Connection) -> Result<(), anyhow::Error> {
             Ok(line) => match line.as_str() {
                 ".exit" => break,
                 ".clear" => {
-                    //todo: this could not work on windows
-                    print!("{esc}[2J{esc}[1;1H", esc = 27 as char);
-                    std::io::stdout().flush().ok();
+                    rl.clear_screen().ok();
                 }
                 sql => {
                     rl.add_history_entry(sql).ok();

crates/core/src/db/relational_db.rs

@@ -256,6 +256,14 @@ impl RelationalDB {
     {
         let mut tx = self.begin_tx();
         let res = f(&mut tx);
+        self.finish_tx(tx, res)
+    }
+
+    /// Perform the transactional logic for the `tx` according to the `res`
+    pub fn finish_tx<A, E>(&self, tx: MutTxId, res: Result<A, E>) -> Result<A, E>
+    where
+        E: From<DBError>,
+    {
         if res.is_err() {
             self.rollback_tx(tx);
         } else {