Fixes showing server errors on cli sql calls (#1720)

clockworklabs · Sep 18, 2024 · 3179f6d · 3179f6d · github-actions · Sep 18, 2024
1 parent db29ded
commit 3179f6d
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/crates/cli/src/errors.rs b/crates/cli/src/errors.rs
@@ -25,7 +25,8 @@ pub async fn error_for_status(response: Response) -> Result<Response, CliError>
     if let Some(kind) = status
         .is_client_error()
         .then_some(RequestSource::Client)
-        .or_else(|| status.is_client_error().then_some(RequestSource::Server))
+        // Anything that is not a success is an error for the client, even a redirect that is not followed.
+        .or_else(|| (!status.is_success()).then_some(RequestSource::Server))
     {
         let msg = response.text().await?;
         return Err(CliError::Request { kind, msg, status });