Skip to content

Commit

Permalink
sdk: Lower client cache log severities (#162)
Browse files Browse the repository at this point in the history
* sdk: Lower client cache log severities

In particular, avoid logging entire rows above `trace`.
  • Loading branch information
kim authored Aug 10, 2023
1 parent 22e1af8 commit 5bdd0b9
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions crates/sdk/src/client_cache.rs
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,10 @@ impl<T: TableType> TableCache<T> {
}
Ok(value) => {
if op_is_delete(op) {
log::info!("Got delete event for {:?} row {:?}", T::TABLE_NAME, value,);
log::trace!("Got delete event for {:?} row {:?}", T::TABLE_NAME, value,);
self.delete(callbacks, row_pk, value);
} else if op_is_insert(op) {
log::info!("Got insert event for {:?} row {:?}", T::TABLE_NAME, value,);
log::trace!("Got insert event for {:?} row {:?}", T::TABLE_NAME, value,);
self.insert(callbacks, row_pk, value);
} else {
log::error!("Unknown table_row_operation::OperationType {}", op);
Expand Down Expand Up @@ -238,7 +238,7 @@ impl<T: TableType> TableCache<T> {
);
}
Ok(row) => {
log::info!("Initializing table {:?}: got new row {:?}", T::TABLE_NAME, row);
log::trace!("Initializing table {:?}: got new row {:?}", T::TABLE_NAME, row);
diff.insert(row_pk, DiffEntry::Insert(row));
}
},
Expand All @@ -247,7 +247,7 @@ impl<T: TableType> TableCache<T> {
diff.insert(row_pk, diff_entry);
}
Some(DiffEntry::Delete(row)) => {
log::info!("Initializing table {:?}: row {:?} remains present", T::TABLE_NAME, row);
log::trace!("Initializing table {:?}: row {:?} remains present", T::TABLE_NAME, row);
diff.insert(row_pk, DiffEntry::NoChange(row));
}
};
Expand Down Expand Up @@ -350,10 +350,10 @@ impl<T: TableWithPrimaryKey> TableCache<T> {
}
Ok(row) => {
if op_is_delete(op) {
log::info!("Got delete event for {:?} row {:?}", T::TABLE_NAME, row,);
log::trace!("Got delete event for {:?} row {:?}", T::TABLE_NAME, row,);
Some(DiffEntry::Delete(row_pk, row))
} else if op_is_insert(op) {
log::info!("Got insert event for {:?} row {:?}", T::TABLE_NAME, row,);
log::trace!("Got insert event for {:?} row {:?}", T::TABLE_NAME, row,);
Some(DiffEntry::Insert(row_pk, row))
} else {
log::error!("Unknown table_row_operation::OperationType {}", op);
Expand Down

0 comments on commit 5bdd0b9

Please sign in to comment.