Review Feedback

clockworklabs · Sep 20, 2024 · 7180d99 · 7180d99
1 parent 79e4162
commit 7180d99
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 8 deletions.
diff --git a/crates/bindings-csharp/Runtime/Attrs.cs b/crates/bindings-csharp/Runtime/Attrs.cs
@@ -78,9 +78,9 @@ public static class ReducerKind
 }
 
 [AttributeUsage(AttributeTargets.Method, Inherited = false)]
-public sealed class ReducerAttribute : Attribute
+public sealed class ReducerAttribute(string? name = null) : Attribute
 {
-    public string? Name;
+    public string? Name => name;
 }
 
 
diff --git a/crates/sdk/tests/connect_disconnect_client/src/module_bindings/mod.rs b/crates/sdk/tests/connect_disconnect_client/src/module_bindings/mod.rs
diff --git a/modules/sdk-test-connect-disconnect-cs/Lib.cs b/modules/sdk-test-connect-disconnect-cs/Lib.cs
@@ -14,14 +14,14 @@ public partial struct Disconnected {
 
 static partial class Module
 {
-    [SpacetimeDB.Reducer(Name = ReducerKind.Connect)]
+    [SpacetimeDB.Reducer(ReducerKind.Connect)]
     public static void OnConnect(ReducerContext ctx)
     {
         var row = new Connected { identity = ctx.Sender };
         ctx.Db.Connected.Insert(ref row);
     }
 
-    [SpacetimeDB.Reducer(Name = ReducerKind.Disconnect)]
+    [SpacetimeDB.Reducer(ReducerKind.Disconnect)]
     public static void OnDisconnect(ReducerContext ctx)
     {
         var row = new Disconnected { identity = ctx.Sender };

diff --git a/modules/spacetimedb-quickstart-cs/Lib.cs b/modules/spacetimedb-quickstart-cs/Lib.cs
@@ -13,14 +13,14 @@ public partial struct Person {
 
 static partial class Module
 {
-    [Reducer(Name = "add")]
+    [Reducer("add")]
     public static void Add(ReducerContext ctx, string name, byte age)
     {
         var row = new Person { Name = name, Age = age };
         ctx.Db.Person.Insert(ref row);
     }
 
-    [Reducer(Name = "say_hello")]
+    [Reducer("say_hello")]
     public static void SayHello(ReducerContext ctx)
     {
         foreach (var person in ctx.Db.Person.Iter())
@@ -30,7 +30,7 @@ public static void SayHello(ReducerContext ctx)
         Runtime.Log("Hello, World!");
     }
 
-    [Reducer(Name = "list_over_age")]
+    [Reducer("list_over_age")]
     public static void ListOverAge(ReducerContext ctx, byte age)
     {
         foreach (var person in ctx.Db.Person.Query(person => person.Age >= age))