Don't add ill-advised API

clockworklabs · Jul 20, 2023 · 9f86adb · 9f86adb
1 parent 8718a39
commit 9f86adb
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/crates/core/src/db/datastore/locking_tx_datastore/mod.rs b/crates/core/src/db/datastore/locking_tx_datastore/mod.rs
@@ -102,10 +102,6 @@ impl DataRef {
     pub fn view(&self) -> &ProductValue {
         &self.data
     }
-
-    pub fn consume(self) -> ProductValue {
-        self.data
-    }
 }
 
 pub struct MutTxId {

diff --git a/crates/core/src/host/instance_env.rs b/crates/core/src/host/instance_env.rs
@@ -399,7 +399,6 @@ impl InstanceEnv {
         let relational_db = self.dbic.relational_db.clone();
         let tx = self.tx.clone();
 
-        // An alternative
         let generator = gen!({
             let stdb = &*relational_db;
             let mut tx = &mut *tx.get()?;
@@ -408,7 +407,7 @@ impl InstanceEnv {
             yield_!(IterItem::Header(schema));
 
             for row in stdb.iter(tx, table_id)? {
-                yield_!(IterItem::Row(row.consume()));
+                yield_!(IterItem::Row(row.view().clone()));
             }
 
             Ok(())