Skip to content

Commit

Permalink
[C#] Remove .Query support (#1772)
Browse files Browse the repository at this point in the history
  • Loading branch information
@RReverser
RReverser authored Sep 30, 2024
1 parent 0375bcb commit bcdea57
Show file tree
Hide file tree
Showing 14 changed files with 21 additions and 476 deletions.
82 changes: 17 additions & 65 deletions ...bindings-csharp/Codegen.Tests/fixtures/diag/snapshots/ExtraCompilationErrors.verified.txt
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 0 additions & 30 deletions crates/bindings-csharp/Codegen.Tests/fixtures/diag/snapshots/Module#FFI.verified.cs
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 0 additions & 8 deletions ...ngs-csharp/Codegen.Tests/fixtures/diag/snapshots/Module#TestAutoIncNotInteger.verified.cs
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 0 additions & 11 deletions ...gs-csharp/Codegen.Tests/fixtures/diag/snapshots/Module#TestUniqueNotEquatable.verified.cs
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

2 comments on commit bcdea57

@github-actions
Copy link

@github-actions github-actions bot commented on bcdea57 Sep 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Callgrind benchmark results

Callgrind Benchmark Report

These benchmarks were run using callgrind,
an instruction-level profiler. They allow comparisons between sqlite (sqlite), SpacetimeDB running through a module (stdb_module), and the underlying SpacetimeDB data storage engine (stdb_raw). Callgrind emulates a CPU to collect the below estimates.

Measurement changes larger than five percent are in bold.

In-memory benchmarks

callgrind: empty transaction

db total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw 5395 5395 0.00% 5471 5471 0.00%
sqlite 5555 5555 0.00% 6043 6043 0.00%

callgrind: filter

db schema indices count preload _column data_type total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw u32_u64_str no_index 64 128 2 string 117797 117797 0.00% 118193 118249 -0.05%
stdb_raw u32_u64_str no_index 64 128 1 u64 75385 75385 0.00% 75659 75663 -0.01%
stdb_raw u32_u64_str btree_each_column 64 128 2 string 24054 24054 0.00% 24434 24434 0.00%
stdb_raw u32_u64_str btree_each_column 64 128 1 u64 23021 23021 0.00% 23399 23395 0.02%
sqlite u32_u64_str no_index 64 128 2 string 144677 144677 0.00% 146207 146211 -0.00%
sqlite u32_u64_str no_index 64 128 1 u64 124026 124044 -0.01% 125346 125388 -0.03%
sqlite u32_u64_str btree_each_column 64 128 2 string 134476 134476 0.00% 136134 136126 0.01%
sqlite u32_u64_str btree_each_column 64 128 1 u64 131343 131343 0.00% 132863 132871 -0.01%

callgrind: insert bulk

db schema indices count preload total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw u32_u64_str unique_0 64 128 902471 902352 0.01% 954153 953950 0.02%
stdb_raw u32_u64_str btree_each_column 64 128 1051725 1055781 -0.38% 1116097 1089513 2.44%
sqlite u32_u64_str unique_0 64 128 398292 398292 0.00% 414896 414896 0.00%
sqlite u32_u64_str btree_each_column 64 128 983609 983609 0.00% 1020463 1020475 -0.00%

callgrind: iterate

db schema indices count total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw u32_u64_str unique_0 1024 152681 152681 0.00% 152719 152719 0.00%
stdb_raw u32_u64_str unique_0 64 15706 15706 0.00% 15744 15744 0.00%
sqlite u32_u64_str unique_0 1024 1068223 1068223 0.00% 1071583 1071583 0.00%
sqlite u32_u64_str unique_0 64 76209 76209 0.00% 77251 77251 0.00%

callgrind: serialize_product_value

count format total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
64 json 47118 47118 0.00% 49804 49804 0.00%
64 bsatn 25716 25716 0.00% 28028 28028 0.00%
16 json 12062 12062 0.00% 14000 14000 0.00%
16 bsatn 8117 8117 0.00% 9545 9545 0.00%

callgrind: update bulk

db schema indices count preload total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw u32_u64_str unique_0 1024 1024 20712924 20497162 1.05% 21520882 21297270 1.05%
stdb_raw u32_u64_str unique_0 64 128 1308072 1307835 0.02% 1394492 1394179 0.02%
sqlite u32_u64_str unique_0 1024 1024 1802091 1802091 0.00% 1811427 1811427 0.00%
sqlite u32_u64_str unique_0 64 128 128437 128443 -0.00% 131167 131173 -0.00%
On-disk benchmarks

callgrind: empty transaction

db total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw 5405 5405 0.00% 5485 5485 0.00%
sqlite 5613 5613 0.00% 6213 6213 0.00%

callgrind: filter

db schema indices count preload _column data_type total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw u32_u64_str no_index 64 128 2 string 117807 117807 0.00% 118187 118171 0.01%
stdb_raw u32_u64_str no_index 64 128 1 u64 75395 75395 0.00% 75665 75665 0.00%
stdb_raw u32_u64_str btree_each_column 64 128 2 string 24064 24069 -0.02% 24436 24441 -0.02%
stdb_raw u32_u64_str btree_each_column 64 128 1 u64 23031 23031 0.00% 23401 23401 0.00%
sqlite u32_u64_str no_index 64 128 2 string 146598 146598 0.00% 148468 148472 -0.00%
sqlite u32_u64_str no_index 64 128 1 u64 125947 125980 -0.03% 127691 127744 -0.04%
sqlite u32_u64_str btree_each_column 64 128 2 string 136598 136598 0.00% 138794 138798 -0.00%
sqlite u32_u64_str btree_each_column 64 128 1 u64 133439 133439 0.00% 135433 135433 0.00%

callgrind: insert bulk

db schema indices count preload total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw u32_u64_str unique_0 64 128 852428 851897 0.06% 905916 905477 0.05%
stdb_raw u32_u64_str btree_each_column 64 128 1003642 1001281 0.24% 1069294 1066865 0.23%
sqlite u32_u64_str unique_0 64 128 415829 415829 0.00% 431719 431707 0.00%
sqlite u32_u64_str btree_each_column 64 128 1021870 1021870 0.00% 1057902 1057894 0.00%

callgrind: iterate

db schema indices count total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw u32_u64_str unique_0 1024 152691 152691 0.00% 152725 152725 0.00%
stdb_raw u32_u64_str unique_0 64 15716 15716 0.00% 15750 15750 0.00%
sqlite u32_u64_str unique_0 1024 1071291 1071291 0.00% 1075037 1075037 0.00%
sqlite u32_u64_str unique_0 64 77981 77981 0.00% 79263 79263 0.00%

callgrind: serialize_product_value

count format total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
64 json 47118 47118 0.00% 49804 49804 0.00%
64 bsatn 25716 25716 0.00% 28028 28028 0.00%
16 json 12062 12062 0.00% 14000 14000 0.00%
16 bsatn 8117 8117 0.00% 9545 9545 0.00%

callgrind: update bulk

db schema indices count preload total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw u32_u64_str unique_0 1024 1024 19412193 19419557 -0.04% 20303401 20312791 -0.05%
stdb_raw u32_u64_str unique_0 64 128 1259841 1259882 -0.00% 1345809 1345822 -0.00%
sqlite u32_u64_str unique_0 1024 1024 1809652 1809652 0.00% 1818240 1818240 0.00%
sqlite u32_u64_str unique_0 64 128 132563 132563 0.00% 135537 135537 0.00%

@github-actions
Copy link

@github-actions github-actions bot commented on bcdea57 Sep 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Criterion benchmark results

Error when comparing benchmarks:

Caused by:

Please sign in to comment.