client-api: make some BAD_REQUEST into NOT_FOUND (#1768)

crates/client-api/src/routes/identity.rs

@@ -287,7 +287,7 @@ pub async fn confirm_recovery_code<S: ControlStateDelegate + NodeDelegate>(
     let recovery_code = recovery_codes
         .into_iter()
         .find(|rc| rc.code == code.as_str())
-        .ok_or((StatusCode::BAD_REQUEST, "Recovery code not found."))?;
+        .ok_or((StatusCode::NOT_FOUND, "Recovery code not found."))?;
 
     let duration = Utc::now() - recovery_code.generation_time;
     if duration.num_seconds() > 60 * 10 {
@@ -310,7 +310,7 @@ pub async fn confirm_recovery_code<S: ControlStateDelegate + NodeDelegate>(
         .any(|a| a.identity == identity)
     {
         // This can happen if someone changes their associated email during a recovery request.
-        return Err((StatusCode::BAD_REQUEST, "No identity associated with that email.").into());
+        return Err((StatusCode::NOT_FOUND, "No identity associated with that email.").into());
     }
 
     // Recovery code is verified, return the identity and token to the user

crates/client-api/src/routes/subscribe.rs

@@ -87,10 +87,10 @@ where
     let database = ctx
         .get_database_by_address(&db_address)
         .unwrap()
-        .ok_or(StatusCode::BAD_REQUEST)?;
+        .ok_or(StatusCode::NOT_FOUND)?;
     let database_instance = ctx
         .get_leader_database_instance_by_database(database.id)
-        .ok_or(StatusCode::BAD_REQUEST)?;
+        .ok_or(StatusCode::NOT_FOUND)?;
     let instance_id = database_instance.id;
 
     let identity_token = auth.creds.token().to_owned();

crates/client-api/src/util.rs

@@ -109,14 +109,14 @@ impl NameOrAddress {
         })
     }
 
-    /// A variant of [`Self::try_resolve()`] which maps to a 400 (Bad Request)
+    /// A variant of [`Self::try_resolve()`] which maps to a 404 (Not Found)
     /// response if `self` is a [`NameOrAddress::Name`] for which no
     /// corresponding [`Address`] is found in the SpacetimeDB DNS.
     pub async fn resolve(
         &self,
         ctx: &(impl ControlStateReadAccess + ?Sized),
     ) -> axum::response::Result<ResolvedAddress> {
-        self.try_resolve(ctx).await?.map_err(|_| StatusCode::BAD_REQUEST.into())
+        self.try_resolve(ctx).await?.map_err(|_| StatusCode::NOT_FOUND.into())
     }
 }