Commit test clients' module_bindings (#346)

* Commit test clients' module_bindings

Having discussed with the team, I've come around to it being correct
to commit the `module_bindings` for the SDK tests' two test clients.

This way, people not working on codegen can run `cargo test --workspace` &c,
and open the test clients with rust-analyzer without any additional rigamarole.

The downside is that any time codegen changes,
we'll see very large commits touching all of these files,
but consensus is we don't really care.

An additional upside is that now we can run clippy against the bindings in CI,
which will incentivize ensuring that the bindings generate lint-free code.

* Add linguist-generated=true for generated module bindings

* Top-level .gitattributes sets `module_bindings` as generated

.gitattributes

@@ -0,0 +1 @@
+**/module_bindings/** linguist-generated=true

.github/workflows/ci.yml

@@ -36,7 +36,7 @@ jobs:
           sudo chmod 777 /stdb
 
       - name: Run cargo test
-        run: cargo test --all --exclude test-client --exclude connect_disconnect_client --features odb_rocksdb,odb_sled
+        run: cargo test --all --features odb_rocksdb,odb_sled
 
   lints:
     name: Lints
@@ -52,7 +52,7 @@ jobs:
         run: cargo fmt --all -- --check
 
       - name: Run cargo clippy
-        run: cargo clippy --all --exclude test-client --exclude connect_disconnect_client --tests --features odb_rocksdb,odb_sled -- -D warnings
+        run: cargo clippy --all --tests --features odb_rocksdb,odb_sled -- -D warnings
 
   wasm_bindings:
     name: Build and test wasm bindings

crates/cli/src/subcommands/generate/rust.rs

@@ -990,21 +990,29 @@ fn print_handle_resubscribe_defn(out: &mut Indenter, items: &[GenItem]) {
 /// to `ReducerCallbacks::handle_event_of_type` with an appropriate type argument.
 fn print_handle_event_defn(out: &mut Indenter, items: &[GenItem]) {
     out.delimited_block(
-        "fn handle_event(&self, event: Event, reducer_callbacks: &mut ReducerCallbacks, state: Arc<ClientCache>) -> Option<Arc<AnyReducerEvent>> {",
+        "fn handle_event(&self, event: Event, _reducer_callbacks: &mut ReducerCallbacks, _state: Arc<ClientCache>) -> Option<Arc<AnyReducerEvent>> {",
         |out| {
             out.delimited_block(
                 "let Some(function_call) = &event.function_call else {",
                 |out| writeln!(out, "spacetimedb_sdk::log::warn!(\"Received Event with None function_call\"); return None;")
                     .unwrap(),
                 "};\n",
             );
+
+            // If the module defines no reducers,
+            // we'll generate a single match arm, the fallthrough.
+            // Clippy doesn't like this, as it could be a `let` binding,
+            // but we're not going to add logic to handle that case,
+            // so just quiet the lint.
+            writeln!(out, "#[allow(clippy::match_single_binding)]").unwrap();
+
             out.delimited_block(
                 "match &function_call.reducer[..] {",
                 |out| {
                     for reducer in iter_reducer_items(items) {
                         writeln!(
                             out,
-                            "{:?} => reducer_callbacks.handle_event_of_type::<{}::{}, ReducerEvent>(event, state, ReducerEvent::{}),",
+                            "{:?} => _reducer_callbacks.handle_event_of_type::<{}::{}, ReducerEvent>(event, _state, ReducerEvent::{}),",
                             reducer.name,
                             reducer_module_name(reducer),
                             reducer_type_name(reducer),

crates/sdk/tests/connect_disconnect_client/src/main.rs

@@ -1,4 +1,3 @@
-#[rustfmt::skip]
 mod module_bindings;
 
 use module_bindings::*;

crates/sdk/tests/test-client/src/main.rs

@@ -9,7 +9,6 @@ use spacetimedb_sdk::{
 
 #[allow(clippy::too_many_arguments)]
 #[allow(clippy::large_enum_variant)]
-#[rustfmt::skip]
 mod module_bindings;
 
 use module_bindings::*;