-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Websocket API: Light transaction updates & NoSuccessNotify
#1812
Open
Centril
wants to merge
7
commits into
master
Choose a base branch
from
centril/websocket-light
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
centril/websocket-light
branch
from
October 9, 2024 16:22
96c58b8
to
ff2e1d8
Compare
Centril
force-pushed
the
centril/websocket-gzip
branch
from
October 9, 2024 16:26
7402785
to
266d6fa
Compare
Centril
force-pushed
the
centril/websocket-light
branch
from
October 9, 2024 17:30
ff2e1d8
to
32e1a6c
Compare
Centril
force-pushed
the
centril/websocket-light
branch
from
October 14, 2024 14:44
c7729ee
to
2a9424e
Compare
Centril
requested review from
bfops,
jdetter and
cloutiertyler
as code owners
October 14, 2024 14:44
Centril
force-pushed
the
centril/websocket-light
branch
from
October 14, 2024 15:27
a8e222e
to
b51292b
Compare
Looks like the tests are failing? |
Centril
force-pushed
the
centril/websocket-light
branch
4 times, most recently
from
October 15, 2024 21:57
d09d4b6
to
da45a60
Compare
… unless NoSuccessNotify
Centril
force-pushed
the
centril/websocket-light
branch
from
October 15, 2024 22:13
da45a60
to
e39d51e
Compare
Centril
force-pushed
the
centril/websocket-light
branch
from
October 16, 2024 14:03
ad931a1
to
e2fabc9
Compare
Centril
force-pushed
the
centril/websocket-light
branch
from
October 17, 2024 14:29
e2fabc9
to
0cb3389
Compare
@Centril I'm happy to review the CLI changes - Do you have recommendations on how to test this? Should I just regenerate bindings for an example client for each language? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Does two things:
TransactionUpdateLight
that consists only of therequest_id
and theDatabaseUpdate<F>
. This is emitted when the query param&light=true
is set (unless the update is sent to the caller in which case a full update is sent).flags: enum CallReducerFlags { FullUpdate, NoSuccessNotify }
toClientMessage
. WhenNoSuccessNotify
is set, the host will not send back an empty update to the caller on success without the caller having subscribed to any affected queries. This is exposed in the SDK viactx.set_reducer_flags.my_reducer(CallReducerFlags::NoSuccessNotify)
. When the defaultFullUpdate
is used, full updates are sent, whether the caller was subscribed to the relevant queries or not.TODO:
API and ABI breaking changes
This breaks the websocket API/protocol.