Websocket API: Light transaction updates & NoSuccessNotify
#1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
centril/websocket-light
branch
from
96c58b8
to
ff2e1d8
Compare
Centril
force-pushed
the
centril/websocket-gzip
branch
from
7402785
to
266d6fa
Compare
Centril
force-pushed
the
centril/websocket-light
branch
from
ff2e1d8
to
32e1a6c
Compare
Centril
force-pushed
the
centril/websocket-light
branch
from
c7729ee
to
2a9424e
Compare
Centril
requested review from
bfops,
jdetter and
cloutiertyler
as code owners
Centril
force-pushed
the
centril/websocket-light
branch
from
a8e222e
to
b51292b
Compare
|
Looks like the tests are failing? |
Centril
force-pushed
the
centril/websocket-light
branch
4 times, most recently
from
d09d4b6
to
da45a60
Compare
… unless NoSuccessNotify
Centril
force-pushed
the
centril/websocket-light
branch
from
da45a60
to
e39d51e
Compare
Centril
force-pushed
the
centril/websocket-light
branch
from
ad931a1
to
e2fabc9
Compare
Centril
force-pushed
the
centril/websocket-light
branch
from
e2fabc9
to
0cb3389
Compare
|
@Centril I'm happy to review the CLI changes - Do you have recommendations on how to test this? Should I just regenerate bindings for an example client for each language? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Does two things:
TransactionUpdateLightthat consists only of therequest_idand theDatabaseUpdate<F>. This is emitted when the query param&light=trueis set (unless the update is sent to the caller in which case a full update is sent).flags: enum CallReducerFlags { FullUpdate, NoSuccessNotify }toClientMessage. WhenNoSuccessNotifyis set, the host will not send back an empty update to the caller on success without the caller having subscribed to any affected queries. This is exposed in the SDK viactx.set_reducer_flags.my_reducer(CallReducerFlags::NoSuccessNotify). When the defaultFullUpdateis used, full updates are sent, whether the caller was subscribed to the relevant queries or not.TODO:
API and ABI breaking changes
This breaks the websocket API/protocol.