-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed C# reducer signature #10
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urn wether or not reducer has subscribers; Moved all ReducerEvent and ReducerArgs code into a single file
Centril
reviewed
Jun 22, 2023
Co-authored-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com> Signed-off-by: John Detter <4099508+jdetter@users.noreply.github.com>
jdetter
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested against d9a4e4b161c8956ae6f6ace5c5286843bd443a11, works for me 👍
cloutiertyler
pushed a commit
that referenced
this pull request
Aug 1, 2023
…urn wether or not reducer has subscribers; Moved all ReducerEvent and ReducerArgs code into a single file (#10) Co-authored-by: Steve <steve@codefics.com>
cloutiertyler
pushed a commit
that referenced
this pull request
Aug 1, 2023
…urn wether or not reducer has subscribers; Moved all ReducerEvent and ReducerArgs code into a single file (#10) Co-authored-by: Steve <steve@codefics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
ReducerEvent
and reducer-specific arguments. Generated events also now have delegates for better UXTimestamp
andIdentity
properties toReducerEvent
None
toReducerType
enum to avoid potential corruption from uninitializedReducerEvent
instancesReducerEvent
andReducerArgs
code into a single file for better UXAPI
If the API is breaking, please state below what will break