Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed C# reducer signature #10

Merged
merged 12 commits into from
Jun 26, 2023
Merged

Conversation

SteveBoytsun
Copy link
Contributor

Description of Changes

  • Changed C# reducer signature to include only ReducerEvent and reducer-specific arguments. Generated events also now have delegates for better UX
  • Added Timestamp and Identity properties to ReducerEvent
  • Added None to ReducerType enum to avoid potential corruption from uninitialized ReducerEvent instances
  • Change C# reducer invocation method to return whether or not reducer has subscribers. This allows us to have an event for handling errors from reducers without handlers (see SDK PR #31)
  • Moved all ReducerEvent and ReducerArgs code into a single file for better UX

API

  • This is a breaking change to the module API
  • This is a breaking change to the ClientAPI

If the API is breaking, please state below what will break

…urn wether or not reducer has subscribers; Moved all ReducerEvent and ReducerArgs code into a single file
@SteveBoytsun SteveBoytsun mentioned this pull request Jun 22, 2023
2 tasks
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against d9a4e4b161c8956ae6f6ace5c5286843bd443a11, works for me 👍

@SteveBoytsun SteveBoytsun merged commit 5eee895 into master Jun 26, 2023
cloutiertyler pushed a commit that referenced this pull request Aug 1, 2023
…urn wether or not reducer has subscribers; Moved all ReducerEvent and ReducerArgs code into a single file (#10)

Co-authored-by: Steve <steve@codefics.com>
cloutiertyler pushed a commit that referenced this pull request Aug 1, 2023
…urn wether or not reducer has subscribers; Moved all ReducerEvent and ReducerArgs code into a single file (#10)

Co-authored-by: Steve <steve@codefics.com>
@cloutiertyler cloutiertyler deleted the change-csharp-reducer-signature branch August 1, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants