Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update client_api.proto docs based on my new understanding. #101

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

gefjon
Copy link
Contributor

@gefjon gefjon commented Jul 26, 2023

Description of Changes

Edits a few doc comments in client_api.proto to resolve questions I asked myself while writing the initial docs.

API

  • This is a breaking change to the module API
  • This is a breaking change to the ClientAPI
  • This is a breaking change to the SDK API

If the API is breaking, please state below what will break

@gefjon gefjon requested a review from Centril July 26, 2023 15:18
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some formatting nits.

crates/client-api-messages/protobuf/client_api.proto Outdated Show resolved Hide resolved
crates/client-api-messages/protobuf/client_api.proto Outdated Show resolved Hide resolved
crates/client-api-messages/protobuf/client_api.proto Outdated Show resolved Hide resolved
@gefjon gefjon enabled auto-merge (squash) July 26, 2023 15:57
@gefjon gefjon merged commit d6df873 into master Jul 26, 2023
4 checks passed
cloutiertyler pushed a commit that referenced this pull request Aug 1, 2023
Edit a few doc comments in client_api.proto to resolve questions I asked myself while writing the initial docs.
cloutiertyler pushed a commit that referenced this pull request Aug 1, 2023
Edit a few doc comments in client_api.proto to resolve questions I asked myself while writing the initial docs.
@cloutiertyler cloutiertyler deleted the phoebe/client-messages-doc-fixes branch August 1, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants