Bindings: improve docs precision #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
requested review from
gefjon and
kulakowski
and removed request for
gefjon
kulakowski
reviewed
Aug 10, 2023
kulakowski
reviewed
Aug 10, 2023
kulakowski
reviewed
Aug 10, 2023
kulakowski
reviewed
Aug 10, 2023
| /// - `(value, value_len)` doesn't decode from BSATN to an `AlgebraicValue` | ||
| /// according to the `AlgebraicType` that the table's schema specifies for `col_id`. | ||
| /// - `value + value_len` overflows a 64-bit integer | ||
| /// - writing to `out` would overflow a 64-bit integer |
There was a problem hiding this comment.
again out, 32 or 64 bit?
kulakowski
reviewed
Aug 10, 2023
kulakowski
force-pushed
the
centril/bindings-docs-precision
branch
from
71409ae
to
1f141fb
Compare
kulakowski
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Improve precision in the bindings, bindings-sys, wasm_instance_env docs.
API
If the API is breaking, please state below what will break