Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoketests work on macos #15

Merged
merged 5 commits into from
Jun 23, 2023
Merged

Smoketests work on macos #15

merged 5 commits into from
Jun 23, 2023

Conversation

jdetter
Copy link
Collaborator

@jdetter jdetter commented Jun 23, 2023

Description of Changes

  • All smoketests that are known to pass are now working on macos

API

  • This is a breaking change to the module API
  • This is a breaking change to the ClientAPI

If the API is breaking, please state below what will break

@jdetter jdetter marked this pull request as ready for review June 23, 2023 03:54
@jdetter jdetter enabled auto-merge (squash) June 23, 2023 04:00
Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdetter jdetter merged commit 0969e7e into master Jun 23, 2023
cloutiertyler pushed a commit that referenced this pull request Aug 1, 2023
* Some work

* Getting smoketests working on mac

* All tests are passing except known failing tests

---------

Co-authored-by: Boppy <no-reply@boppygames.gg>
cloutiertyler pushed a commit that referenced this pull request Aug 1, 2023
* Some work

* Getting smoketests working on mac

* All tests are passing except known failing tests

---------

Co-authored-by: Boppy <no-reply@boppygames.gg>
@cloutiertyler cloutiertyler deleted the jdetter/all-smoketests-on-mac branch August 1, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants