[WASM ABI 1.0] impl __call_reducer__ using bytes_source_read
#1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
commented
Aug 19, 2024
Comment on lines
+465
to
+467
| if args == BytesSource::INVALID { | ||
| return logic(&[]); | ||
| } |
There was a problem hiding this comment.
cc @cloutiertyler -- slight tweak to the WASM ABI proposal: the host can/will send __call_reducer__ an invalid args which means that the arguments are empty. This is useful as it allows us to avoid a host call as well as avoid allocation. The primary winner for this I imagine are the connect/disconnect reducers.
There was a problem hiding this comment.
If we're tweaking the proposal, please make sure changes make it back into the proposal.
Centril
force-pushed
the
centril/bytes-source-read
branch
from
4376778
to
23fdafc
Compare
RReverser
reviewed
Aug 19, 2024
RReverser
reviewed
Aug 19, 2024
Centril
force-pushed
the
centril/call-reducer-by-val
branch
from
04d6561
to
2bc2538
Compare
Centril
force-pushed
the
centril/bytes-source-read
branch
from
ff4791b
to
99cbc90
Compare
Centril
force-pushed
the
centril/call-reducer-by-val
branch
from
74e571f
to
5877d30
Compare
Centril
force-pushed
the
centril/bytes-source-read
branch
from
99cbc90
to
cedf36a
Compare
coolreader18
approved these changes
Aug 19, 2024
Centril
force-pushed
the
centril/bytes-source-read
branch
from
cedf36a
to
08590c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This adds
_bytes_source_readand implements__call_reducer__with it.Meanwhile,
_buffer_lenand_buffer_consumeare removed.cc #1460