Automatic migration planning #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
| pub prechecks: Vec<AutoMigratePrecheck<'def>>, | ||
| /// The migration steps to perform. | ||
| /// Order should not matter, as the steps are independent. | ||
| pub steps: Vec<AutoMigrateStep<'def>>, |
There was a problem hiding this comment.
Is it guaranteed to not matter, or does it just happen to be that way because of the types of automigration we do now?
cloutiertyler
approved these changes
Sep 4, 2024
kazimuth
force-pushed
the
jgilles/automigrate_plan
branch
from
2cfd74d
to
6691e40
Compare
|
This now also fixes some stuff in ModuleDef introduced by miscommunication while collaborating with Noa |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Implements planning, does not yet integrate.
API and ABI breaking changes
N/A
Expected complexity level and risk
0
Testing
See added tests.