Add edition to .rustfmt.toml #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When invoked standalone (i.e. not through `cargo fmt`), `rustfmt` does not respect the edition (or any other configuration) in `Cargo.toml`, instead relying solely on `rustfmt.toml` or `.rustfmt.toml`. My editor automatically invokes `rustfmt` on individual files on save. Unless `rustfmt` sees a specified edition, it assumes 2018, and rejects any code that uses `async`. This is a huge pain. Specify `edition = "2021"` in `.rustfmt.toml` so that standalone `rustfmt` works. Signed-off-by: Phoebe Goldman <phoebe@clockworklabs.io>
gefjon
added
release-any
joshua-spacetime
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
When invoked standalone (i.e. not through
cargo fmt),rustfmtdoes not respect the edition (or any other configuration) inCargo.toml, instead relying solely onrustfmt.tomlor.rustfmt.toml. My editor automatically invokesrustfmton individual files on save. Unlessrustfmtsees a specified edition, it assumes 2018, and rejects any code that usesasync. This is a huge pain.Specify
edition = "2021"in.rustfmt.tomlso that standalonerustfmtworks.API and ABI breaking changes
N/a
Expected complexity level and risk
0
Testing
N/a