Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI - Remove project-specific config files #1665

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

bfops
Copy link
Collaborator

@bfops bfops commented Sep 4, 2024

Description of Changes

Remove support for project-specific spacetime config files. The global Spacetime config files are unchanged.

We plan to add these back once we have a more principled approach to configs.

Fixes #1666.

API and ABI breaking changes

Breaks anybody using project-specific config files.

Expected complexity level and risk

2

Testing

Just existing smoketests

@bfops bfops added CLI only This change only affects the CLI behavior api-break A PR that breaks some user-visible API labels Sep 4, 2024
@bfops bfops marked this pull request as ready for review September 4, 2024 18:17
@bfops bfops enabled auto-merge September 4, 2024 21:43
@bfops bfops requested review from gefjon and removed request for gefjon September 5, 2024 17:37
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test this myself but we weren't using the project config anywhere so the likelyhood that this breaks something is very low.

@bfops bfops added this pull request to the merge queue Sep 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 23, 2024
@bfops bfops added this pull request to the merge queue Sep 24, 2024
Merged via the queue into master with commit 336056e Sep 24, 2024
15 checks passed
@bfops bfops deleted the bfops/remove-project-config branch September 24, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-break A PR that breaks some user-visible API CLI only This change only affects the CLI behavior release-0.12
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI - Remove support for project-local config files
2 participants